Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2159123003: New `whitespace_around_ops` lint (#249). (Closed)

Created:
4 years, 5 months ago by pquitslund
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/linter.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -3 lines) Patch
M lib/src/rules.dart View 3 chunks +4 lines, -3 lines 0 comments Download
A lib/src/rules/whitespace_around_ops.dart View 1 chunk +73 lines, -0 lines 1 comment Download
A test/rules/whitespace_around_ops.dart View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 5 months ago (2016-07-19 16:41:08 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2159123003/diff/1/lib/src/rules/whitespace_around_ops.dart File lib/src/rules/whitespace_around_ops.dart (right): https://codereview.chromium.org/2159123003/diff/1/lib/src/rules/whitespace_around_ops.dart#newcode60 lib/src/rules/whitespace_around_ops.dart:60: first.offset + (first.length - 1) != second.offset - ...
4 years, 5 months ago (2016-07-19 16:47:51 UTC) #3
pquitslund
On 2016/07/19 16:47:51, Brian Wilkerson wrote: > lgtm > > https://codereview.chromium.org/2159123003/diff/1/lib/src/rules/whitespace_around_ops.dart > File lib/src/rules/whitespace_around_ops.dart (right): ...
4 years, 5 months ago (2016-07-19 19:52:00 UTC) #4
pquitslund
4 years, 5 months ago (2016-07-19 20:00:06 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1fdc9f9388852034ba40f9c9186b7b09aa9daaf1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698