Issue 21555003: Exposing native doubles as doubles when they are read-only or method return values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21555003: Exposing native doubles as doubles when they are read-only or method return values. (Closed)

Created:
7 years, 4 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Exposing native doubles as doubles when they are read-only or method return values. This keeps num for parameters of operations and fields which are settable. Requested because some DOM APIs (such as Performance.now) don't really make sense returning ints. BUG=11133 R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=26817

Patch Set 1 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -186 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	30 chunks	+57 lines, -57 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	30 chunks	+57 lines, -57 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	11 chunks	+16 lines, -16 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	16 chunks	+21 lines, -21 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	2 chunks	+14 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	6 chunks	+5 lines, -8 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	3 chunks	+4 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 3 months ago (2013-08-28 21:07:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r26817 (presubmit successful).

Expand Messages | Collapse Messages