Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 215533005: Fix a bug in [http.BaseRequest.send]'s content length handling. (Closed)

Created:
6 years, 9 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Fix a bug in [http.BaseRequest.send]'s content length handling. BUG= R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=34571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M pkg/http/lib/src/base_request.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/http/test/streamed_request_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/http/test/utils.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
6 years, 9 months ago (2014-03-27 23:10:37 UTC) #1
kevmoo
lgtm
6 years, 9 months ago (2014-03-27 23:25:23 UTC) #2
Sergey Berezin
CQ does not support branches, please commit manually. I'm unchecking the commit box.
6 years, 9 months ago (2014-03-28 16:43:53 UTC) #3
Sergey Berezin
The CQ bit was unchecked by sergeyberezin@chromium.org
6 years, 9 months ago (2014-03-28 16:43:56 UTC) #4
kevmoo
On 2014/03/28 16:43:56, Sergey Berezin wrote: > The CQ bit was unchecked by mailto:sergeyberezin@chromium.org I ...
6 years, 9 months ago (2014-03-28 16:45:15 UTC) #5
nweiz
6 years, 8 months ago (2014-03-31 19:17:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r34571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698