Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 215463002: Move Dart-based analyzer script to packages. (Closed)

Created:
6 years, 9 months ago by scheglov
Modified:
6 years, 9 months ago
Reviewers:
ricow1, Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Move Dart-based analyzer script to packages. Rico, can you please change the performance tool to use this pkg/analyzer/bin/analyzer script? R=brianwilkerson@google.com, ricow@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -56 lines) Patch
D editor/tools/analyzer View 1 chunk +0 lines, -53 lines 0 comments Download
A + pkg/analyzer/bin/analyzer View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years, 9 months ago (2014-03-27 21:00:48 UTC) #1
Brian Wilkerson
LGTM
6 years, 9 months ago (2014-03-27 21:21:42 UTC) #2
ricow1
LGTM, when do we expect this to be ready for prime time so that we ...
6 years, 9 months ago (2014-03-27 21:24:56 UTC) #3
scheglov
On 2014/03/27 21:24:56, ricow1 wrote: > LGTM, when do we expect this to be ready ...
6 years, 9 months ago (2014-03-27 21:28:02 UTC) #4
scheglov
6 years, 9 months ago (2014-03-27 21:38:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r34483 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698