Handle missing imports/exports/parts.

Handle missing imports/exports/parts.

BUG=
R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26341

[ahe, 2013-08-06 15:01:00]

LGTM!

https://codereview.chromium.org/21544003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/apiimpl.dart (right):

https://codereview.chromium.org/21544003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/apiimpl.dart:179:
leg.MessageKind.GENERIC, {'text': 'Error: $exception'});
Could you turn this into a non-generic message?

For example:

Error: Can't read "#{uri}" (#{exception})

https://codereview.chromium.org/21544003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart2jslib.dart (right):

https://codereview.chromium.org/21544003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart2jslib.dart:32: import
'source_file.dart';
Add show SourceFile.

https://codereview.chromium.org/21544003/diff/1/tests/compiler/dart2js/import...
File tests/compiler/dart2js/import_test.dart (right):

https://codereview.chromium.org/21544003/diff/1/tests/compiler/dart2js/import...
tests/compiler/dart2js/import_test.dart:17: import 'dart:bar';
The comment on line 5 implies that you meant package:bar here. I think it makes
sense to test for both.

However, given names as pub and barback, perhaps you'd better not assume that a
library named "dart:bar" or "package:bar" will never exist.

[Johnni Winther, 2013-08-19 08:05:19]

PTAL

https://codereview.chromium.org/21544003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/apiimpl.dart (right):

https://codereview.chromium.org/21544003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/apiimpl.dart:179:
leg.MessageKind.GENERIC, {'text': 'Error: $exception'});
On 2013/08/06 15:01:00, ahe wrote:
> Could you turn this into a non-generic message?
> 
> For example:
> 
> Error: Can't read "#{uri}" (#{exception})

Done.

https://codereview.chromium.org/21544003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart2jslib.dart (right):

https://codereview.chromium.org/21544003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart2jslib.dart:32: import
'source_file.dart';
On 2013/08/06 15:01:00, ahe wrote:
> Add show SourceFile.

Done.

https://codereview.chromium.org/21544003/diff/1/tests/compiler/dart2js/import...
File tests/compiler/dart2js/import_test.dart (right):

https://codereview.chromium.org/21544003/diff/1/tests/compiler/dart2js/import...
tests/compiler/dart2js/import_test.dart:17: import 'dart:bar';
On 2013/08/06 15:01:00, ahe wrote:
> The comment on line 5 implies that you meant package:bar here. I think it
makes
> sense to test for both.
> 
> However, given names as pub and barback, perhaps you'd better not assume that
a
> library named "dart:bar" or "package:bar" will never exist.

Done.

[ahe, 2013-08-19 08:52:58]

LGTM!

It would be nice if you could use MessageKind.examples.

Cheers,
Peter

[Johnni Winther, 2013-08-20 09:20:14]

Committed patchset #4 manually as r26341 (presubmit successful).

[ahe, 2013-08-20 10:18:16]

https://codereview.chromium.org/21544003/diff/25001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/21544003/diff/25001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/warnings.dart:634: static const
MessageKind INTERNAL_LIBRARY_FROM = const MessageKind(
Could you add an example for this as well?

https://codereview.chromium.org/21544003/diff/25001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/warnings.dart:639: 'Error: Internal
library "#{resolvedUri}" is not accessible.');
Ditto.

https://codereview.chromium.org/21544003/diff/25001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/warnings.dart:642: 'Error: Library not
found "#{resolvedUri}".');
Ditto.

https://codereview.chromium.org/21544003/diff/25001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/warnings.dart:756: "Error: Can't read
'#{uri}' (#{exception}).",
howToFix?