Remove support for remaining deprecated features.

Remove support for remaining deprecated features.

BUG=
R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25858

[ahe, 2013-08-06 14:48:40]

LGTM!

https://codereview.chromium.org/21540002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/21540002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2143: //
Unsupported operator.
How is that diagnosed?

https://codereview.chromium.org/21540002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/21540002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:608: 'Error: Operator
=== not supported. Use "identical" instead.');
I'm not sure that the suggestion is good. If you mistype == or !=, you are
getting the wrong hint.

I think the error should be something like:

Error: "===" is not an operator.
Did you mean "#{lhs} == #{rhs}" or "identical(#{lhs}, #{rhs})"?

https://codereview.chromium.org/21540002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:611: 'Error: Operator
!== not supported. Use "!identical" instead.');
Ditto.

https://codereview.chromium.org/21540002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:615: 'Use "rethrow"
instead.');
Error: No expression after "throw".
Did you mean "rethrow"?

https://codereview.chromium.org/21540002/diff/1/tests/language/unsupported_op...
File tests/language/unsupported_operators_test.dart (right):

https://codereview.chromium.org/21540002/diff/1/tests/language/unsupported_op...
tests/language/unsupported_operators_test.dart:11: print(super === null); ///
01: compile-time error
print(
super === /// 01: compile-time error
null)

https://codereview.chromium.org/21540002/diff/1/tests/language/unsupported_op...
tests/language/unsupported_operators_test.dart:12: print(super !== null); ///
02: compile-time error
Ditto.

https://codereview.chromium.org/21540002/diff/1/tests/language/unsupported_op...
tests/language/unsupported_operators_test.dart:17: new C().m(); /// 01:
continued
No need to use continue here.

https://codereview.chromium.org/21540002/diff/1/tests/language/unsupported_op...
tests/language/unsupported_operators_test.dart:19: print("foo" === null); ///
03: compile-time error
print("foo"
=== null /// 03: compile-time error
);

https://codereview.chromium.org/21540002/diff/1/tests/language/unsupported_op...
tests/language/unsupported_operators_test.dart:20: print("foo" !== null); ///
04: compile-time error
Ditto.

[Johnni Winther, 2013-08-07 06:56:25]

https://codereview.chromium.org/21540002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/21540002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2143: //
Unsupported operator.
On 2013/08/06 14:48:40, ahe wrote:
> How is that diagnosed?

An error has been reported during parsing.

Added the explanation to the comment.

https://codereview.chromium.org/21540002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/21540002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:608: 'Error: Operator
=== not supported. Use "identical" instead.');
On 2013/08/06 14:48:40, ahe wrote:
> I'm not sure that the suggestion is good. If you mistype == or !=, you are
> getting the wrong hint.
> 
> I think the error should be something like:
> 
> Error: "===" is not an operator.
> Did you mean "#{lhs} == #{rhs}" or "identical(#{lhs}, #{rhs})"?

Done.

https://codereview.chromium.org/21540002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:611: 'Error: Operator
!== not supported. Use "!identical" instead.');
On 2013/08/06 14:48:40, ahe wrote:
> Ditto.

Done.

https://codereview.chromium.org/21540002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:615: 'Use "rethrow"
instead.');
On 2013/08/06 14:48:40, ahe wrote:
> Error: No expression after "throw".
> Did you mean "rethrow"?

Done.

https://codereview.chromium.org/21540002/diff/1/tests/language/unsupported_op...
File tests/language/unsupported_operators_test.dart (right):

https://codereview.chromium.org/21540002/diff/1/tests/language/unsupported_op...
tests/language/unsupported_operators_test.dart:11: print(super === null); ///
01: compile-time error
On 2013/08/06 14:48:40, ahe wrote:
> print(
> super === /// 01: compile-time error
> null)

Done.

https://codereview.chromium.org/21540002/diff/1/tests/language/unsupported_op...
tests/language/unsupported_operators_test.dart:12: print(super !== null); ///
02: compile-time error
On 2013/08/06 14:48:40, ahe wrote:
> Ditto.

Done.

https://codereview.chromium.org/21540002/diff/1/tests/language/unsupported_op...
tests/language/unsupported_operators_test.dart:17: new C().m(); /// 01:
continued
On 2013/08/06 14:48:40, ahe wrote:
> No need to use continue here.

Done.

https://codereview.chromium.org/21540002/diff/1/tests/language/unsupported_op...
tests/language/unsupported_operators_test.dart:19: print("foo" === null); ///
03: compile-time error
On 2013/08/06 14:48:40, ahe wrote:
> print("foo"
> === null /// 03: compile-time error
> );

Done.

https://codereview.chromium.org/21540002/diff/1/tests/language/unsupported_op...
tests/language/unsupported_operators_test.dart:20: print("foo" !== null); ///
04: compile-time error
On 2013/08/06 14:48:40, ahe wrote:
> Ditto.

Done.

[Johnni Winther, 2013-08-07 06:58:55]

Committed patchset #3 manually as r25858 (presubmit successful).