Issue 215293002: Use ASSERT instead of CHECK_ISOLATE in cases where we derive the isolate from the native Arguments …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215293002: Use ASSERT instead of CHECK_ISOLATE in cases where we derive the isolate from the native Arguments … (Closed)

Created:
6 years, 9 months ago by siva

Modified:
6 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use ASSERT instead of CHECK_ISOLATE in cases where we derive the isolate from the native Arguments structure. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=34488

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View	1	10 chunks	+15 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -ip https://codereview.chromium.org/215293002/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/215293002/diff/1/runtime/vm/dart_api_impl.cc#newcode3933 runtime/vm/dart_api_impl.cc:3933: ASSERT(isolate != NULL); How about ASSERT(isolate == ...

6 years, 9 months ago (2014-03-27 21:05:42 UTC) #2

siva

https://codereview.chromium.org/215293002/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/215293002/diff/1/runtime/vm/dart_api_impl.cc#newcode3933 runtime/vm/dart_api_impl.cc:3933: ASSERT(isolate != NULL); Good point, I will modify the ...

6 years, 9 months ago (2014-03-27 21:55:46 UTC) #3

siva

6 years, 9 months ago (2014-03-27 23:05:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34488 (presubmit successful).

Expand Messages | Collapse Messages

Issue 215293002: Use ASSERT instead of CHECK_ISOLATE in cases where we derive the isolate from the native Arguments … (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages