Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1462)

Issue 2152793003: Remove an extra \r\n and fix a test. (Closed)

Created:
4 years, 5 months ago by nweiz
Modified:
4 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/http@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove an extra \r\n and fix a test. The multipart tests hadn't been updated to expect the content-transfer-encoding header. Closes #40 R=rnystrom@google.com Committed: https://github.com/dart-lang/http/commit/eb11c61e7bc14553e3256acafdb4d0096df18c27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/multipart_request.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/multipart_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 5 months ago (2016-07-14 20:26:11 UTC) #1
Bob Nystrom
lgtm
4 years, 5 months ago (2016-07-18 20:36:44 UTC) #2
nweiz
4 years, 5 months ago (2016-07-19 20:35:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb11c61e7bc14553e3256acafdb4d0096df18c27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698