Issue 215213003: Rework the <field-view> page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215213003: Rework the <field-view> page. (Closed)

Created:
6 years, 9 months ago by turnidge

Modified:
6 years, 9 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rework the <field-view> page. Give fields/functions a consistent notion of ownership. Add field's script to the JSON. Make page reload work again. Fixup closure printing a bit. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34520

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+622 lines, -315 lines)			Patch
M	runtime/bin/resources_sources.gypi	View	1 2	1 chunk	+58 lines, -54 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1 2	7 chunks	+123 lines, -54 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	1 2	6 chunks	+10 lines, -10 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js.map	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html	View	1 2	7 chunks	+123 lines, -54 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View	1 2	6 chunks	+10 lines, -10 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js.map	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/field_ref.html	View	1 2	1 chunk	+16 lines, -12 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/field_view.html	View	1 2	2 chunks	+84 lines, -27 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/function_ref.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/function_view.html	View	1 2	3 chunks	+14 lines, -12 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_ref.html	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html	View	1 2	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/app/location_manager.dart	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/field_ref.html	View	1	1 chunk	+16 lines, -12 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/field_view.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/field_view.html	View	1 2	2 chunks	+84 lines, -27 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/function_ref.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/function_ref.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/function_view.dart	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/function_view.html	View	1 2	3 chunks	+14 lines, -12 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/instance_ref.html	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/instance_view.html	View	1 2	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/response_viewer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/resources.sh	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	3 chunks	+18 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

turnidge

6 years, 9 months ago (2014-03-28 20:21:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r34520 (presubmit successful).

Expand Messages | Collapse Messages