Issue 21520002: Add argument check to Directory and Link constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21520002: Add argument check to Directory and Link constructors (Closed)

Created:
7 years, 4 months ago by Søren Gjesse

Modified:
7 years, 4 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add argument check to Directory and Link constructors These matches the argument check in the File constructor. Minor refactoring of final fields in File and Directory implementations. BUG=http://dartbug.com/11976 R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=25705

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -136 lines)			Patch
M	sdk/lib/io/directory_impl.dart	View	16 chunks	+29 lines, -40 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	40 chunks	+71 lines, -77 lines	0 comments	Download
M	sdk/lib/io/link.dart	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	tests/standalone/io/directory_fuzz_test.dart	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	tests/standalone/io/directory_invalid_arguments_test.dart	View	1 chunk	+2 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

7 years, 4 months ago (2013-08-01 11:32:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25705 (presubmit successful).

Expand Messages | Collapse Messages