Issue 21513005: Report ASSIGNMENT_TO_CONST.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21513005: Report ASSIGNMENT_TO_CONST. (Closed)

Created:
7 years, 4 months ago by scheglov

Modified:
7 years, 4 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report ASSIGNMENT_TO_CONST. Also more language tests triage. Some of the tests were already 'fixed' by reporting warnings, but still fail because they are negative (but should not be negative according to the spec). R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=25713

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -25 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	2 chunks	+11 lines, -10 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java	View	1 chunk	+26 lines, -0 lines	1 comment	Download
M	tests/language/language_analyzer.status	View	8 chunks	+11 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jwren

LGTM https://codereview.chromium.org/21513005/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java (right): https://codereview.chromium.org/21513005/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java#newcode426 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java:426: // TODO(scheglov) TODO?

7 years, 4 months ago (2013-08-01 16:57:54 UTC) #2

scheglov

7 years, 4 months ago (2013-08-01 17:24:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r25713 (presubmit successful).

Expand Messages | Collapse Messages