Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 214933002: Clean-up and progress on analysis server (Closed)

Created:
6 years, 9 months ago by Brian Wilkerson
Modified:
6 years, 8 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean-up and progress on analysis server R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=34529

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -67 lines) Patch
M pkg/analysis_server/lib/http_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_logger.dart View 2 chunks +0 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +10 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/channel.dart View 7 chunks +60 lines, -39 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_context.dart View 6 chunks +62 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_context_test.dart View 4 chunks +23 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Brian Wilkerson
6 years, 9 months ago (2014-03-27 17:01:27 UTC) #1
danrubel
lgtm
6 years, 9 months ago (2014-03-28 20:42:59 UTC) #2
Brian Wilkerson
6 years, 8 months ago (2014-03-28 21:26:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34529 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698