Use the command builtin rather than which.

Use the command builtin rather than which.

Closes #1430

R=floitsch@google.com, kevmoo@google.com

Committed: https://github.com/dart-lang/pub/commit/91a55e366cfe2aabae34f78726e5de2cab5dc412

[kevmoo, 2016-07-14 21:22:13]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-07-14 21:22:13]

DBQ

https://codereview.chromium.org/2148413002/diff/1/lib/src/global_packages.dart
File lib/src/global_packages.dart (right):

https://codereview.chromium.org/2148413002/diff/1/lib/src/global_packages.dar...
lib/src/global_packages.dart:776: var result = runProcessSync("sh", ["-c",
'command -v "\$installed"'],
...or just add 'runInShell: true' ?

[nweiz, 2016-07-14 22:06:57]

https://codereview.chromium.org/2148413002/diff/1/lib/src/global_packages.dart
File lib/src/global_packages.dart (right):

https://codereview.chromium.org/2148413002/diff/1/lib/src/global_packages.dar...
lib/src/global_packages.dart:776: var result = runProcessSync("sh", ["-c",
'command -v "\$installed"'],
On 2016/07/14 21:22:13, kevmoo wrote:
> ...or just add 'runInShell: true' ?

Haha good idea!

[kevmoo, 2016-07-21 20:20:30]

LGTM - but I don't think I was an original reviewer :-/

[floitsch, 2016-07-27 17:53:18]

LGTM.
I'm not sure, if switching from 'bash' to 'sh' could change the resolution of
the path, but I would assume that it works the same.

[nweiz, 2016-07-27 18:53:20]

Description was changed from

==========
Use the command builtin rather than which.

Closes #1430

R=floitsch@google.com
==========

to

==========
Use the command builtin rather than which.

Closes #1430

R=floitsch@google.com, kevmoo@google.com

Committed:
https://github.com/dart-lang/pub/commit/91a55e366cfe2aabae34f78726e5de2cab5dc412
==========

[nweiz, 2016-07-27 18:53:22]

Committed patchset #2 (id:20001) manually as
91a55e366cfe2aabae34f78726e5de2cab5dc412 (presubmit successful).