Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214593008: Rollback pkg/analyzer that breaks code_transformers (Closed)

Created:
6 years, 9 months ago by scheglov
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2372 lines, -1761 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 96 chunks +282 lines, -104 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 32 chunks +93 lines, -53 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 37 chunks +149 lines, -103 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 118 chunks +404 lines, -368 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 177 chunks +433 lines, -361 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 26 chunks +87 lines, -47 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 24 chunks +94 lines, -52 lines 0 comments Download
M pkg/analyzer/lib/src/generated/instrumentation.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 12 chunks +189 lines, -157 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 82 chunks +230 lines, -173 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 34 chunks +249 lines, -184 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 14 chunks +40 lines, -40 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 8 chunks +33 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 2 chunks +19 lines, -19 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 10 chunks +30 lines, -53 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years, 9 months ago (2014-03-27 20:24:09 UTC) #1
blois
lgtm
6 years, 9 months ago (2014-03-27 20:24:59 UTC) #2
Brian Wilkerson
LGTM. Hopefully I can fix the bug this introduced and we can roll it forward ...
6 years, 9 months ago (2014-03-27 20:27:57 UTC) #3
scheglov
Committed patchset #1 manually as r34479 (presubmit successful).
6 years, 9 months ago (2014-03-27 20:29:18 UTC) #4
Siggi Cherem (dart-lang)
6 years, 9 months ago (2014-03-27 20:32:10 UTC) #5
Message was sent while issue was closed. 
lgtm, thanks Konstantin!

Powered by Google App Engine
This is Rietveld 408576698