Add CompilationUnit abstraction for tracking "project files".

Add CompilationUnit abstraction for tracking "project files".

"Project files" is the feature for serving the sources of Try Dart! to itself.

[ahe, 2014-03-27 15:34:11]

I can't figure out how to test this. My plan is to use it for editing Try Dart!
itself. That should get it tested.

I did make some changes that re-enables compilation when opening the site, and
better at kicking off a compilation when a change has occurred. These changes
will be tested by something I'm working on (I shared a Google Doc about this).

[lukechurch, 2014-03-27 16:08:23]

https://codereview.chromium.org/214513005/diff/1/dart/site/try/src/compilatio...
File dart/site/try/src/compilation_unit.dart (right):

https://codereview.chromium.org/214513005/diff/1/dart/site/try/src/compilatio...
dart/site/try/src/compilation_unit.dart:10: 
This seems on first reading like a slightly odd pattern to have a data carrying
superclass that is subclassed with an implementation that adds behaviour.

I'm sure you have a good reason for doing this, could you put a comment in that
explains it :)

https://codereview.chromium.org/214513005/diff/1/dart/site/try/src/interactio...
File dart/site/try/src/interaction_manager.dart (right):

https://codereview.chromium.org/214513005/diff/1/dart/site/try/src/interactio...
dart/site/try/src/interaction_manager.dart:344: mainEditorPane.contentEditable =
'false';
If I read the code below correctly, it's going to re-enable editing again after
it's been fetched? In which case probably adjust the comment in the code about
to 

//Disable editing whilst potentially fetching the project file

[ahe, 2014-03-27 23:32:34]

Thank you for taking a look, Luke.

https://codereview.chromium.org/214513005/diff/1/dart/site/try/src/compilatio...
File dart/site/try/src/compilation_unit.dart (right):

https://codereview.chromium.org/214513005/diff/1/dart/site/try/src/compilatio...
dart/site/try/src/compilation_unit.dart:10: 
On 2014/03/27 16:08:23, lukechurch wrote:
> This seems on first reading like a slightly odd pattern to have a data
carrying
> superclass that is subclassed with an implementation that adds behaviour.
> 
> I'm sure you have a good reason for doing this, could you put a comment in
that
> explains it :)

It creates a private field without creating an abstract data type. I really
don't like library privacy. I'll add a comment.

https://codereview.chromium.org/214513005/diff/1/dart/site/try/src/interactio...
File dart/site/try/src/interaction_manager.dart (right):

https://codereview.chromium.org/214513005/diff/1/dart/site/try/src/interactio...
dart/site/try/src/interaction_manager.dart:344: mainEditorPane.contentEditable =
'false';
On 2014/03/27 16:08:23, lukechurch wrote:
> If I read the code below correctly, it's going to re-enable editing again
after
> it's been fetched? In which case probably adjust the comment in the code about
> to 
> 
> //Disable editing whilst potentially fetching the project file

Good idea.

[ahe, 2014-03-28 10:14:24]

I've added comments.

To make progress, I need someone to approve this change or tell me what is
preventing approval.

[kasperl, 2014-03-28 10:24:51]

LGTM.

https://codereview.chromium.org/214513005/diff/20001/dart/site/try/src/intera...
File dart/site/try/src/interaction_manager.dart (right):

https://codereview.chromium.org/214513005/diff/20001/dart/site/try/src/intera...
dart/site/try/src/interaction_manager.dart:105: CompilationUnit
currentCompilationUnit = new CompilationUnit('fake', '');
Maybe chose a fake name that isn't at all likely (or even legal) for other real
compilation units?

https://codereview.chromium.org/214513005/diff/20001/dart/site/try/src/intera...
dart/site/try/src/interaction_manager.dart:327:
window.localStorage['currentSource'] = unit.content;
Add a setter for currentSource next to the getter?

[ahe, 2014-03-28 11:53:14]

Thank you, Kasper!

https://codereview.chromium.org/214513005/diff/20001/dart/site/try/src/intera...
File dart/site/try/src/interaction_manager.dart (right):

https://codereview.chromium.org/214513005/diff/20001/dart/site/try/src/intera...
dart/site/try/src/interaction_manager.dart:105: CompilationUnit
currentCompilationUnit = new CompilationUnit('fake', '');
On 2014/03/28 10:24:51, kasperl wrote:
> Maybe chose a fake name that isn't at all likely (or even legal) for other
real
> compilation units?

This is a temporary hack. I'll add a todo.

https://codereview.chromium.org/214513005/diff/20001/dart/site/try/src/intera...
dart/site/try/src/interaction_manager.dart:327:
window.localStorage['currentSource'] = unit.content;
On 2014/03/28 10:24:51, kasperl wrote:
> Add a setter for currentSource next to the getter?

Also a temporary hack, but encapsulating the hacks makes sense.

[ahe, 2014-03-28 11:53:15]

Committed patchset #3 manually as r34498 (presubmit successful).