Issue 21440002: Inline CreateClassMirror and remove dead code.

Issue 21440002: Inline CreateClassMirror and remove dead code. (Closed)

Created:
7 years, 4 months ago by Michael Lippautz (Google)

Modified:
7 years, 4 months ago

Reviewers:
rmacnak, siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Inline CreateClassMirror and remove dead code. (Almost) no more embedding API, yay! Fixes issue 12135. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25717

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -120 lines)			Patch
M	runtime/lib/mirrors.cc	View	1 2	7 chunks	+21 lines, -118 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/lib/mirrors/function_type_mirror_test.dart	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rmacnak

https://codereview.chromium.org/21440002/diff/3001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/21440002/diff/3001/runtime/lib/mirrors.cc#newcode153 runtime/lib/mirrors.cc:153: if (cls.IsSignatureClass() && !cls.IsCanonicalSignatureClass()) { If it is a ...

7 years, 4 months ago (2013-08-01 00:06:18 UTC) #2

Michael Lippautz (Google)

Also added further tests to cover creation of functiontype mirrors through closuremirrors. https://codereview.chromium.org/21440002/diff/3001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc ...

7 years, 4 months ago (2013-08-01 17:05:09 UTC) #3

Michael Lippautz (Google)

7 years, 4 months ago (2013-08-01 18:27:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r25717 (presubmit successful).

Expand Messages | Collapse Messages