Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 214373002: Correctly recognize type literals in literal lists and maps in an invocation context. (Closed)

Created:
6 years, 9 months ago by karlklose
Modified:
6 years, 9 months ago
Reviewers:
Johnni Winther, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Correctly recognize type literals in literal lists and maps in an invocation context. R=johnniwinther@google.com BUG= http://dartbug.com/17777 Committed: https://code.google.com/p/dart/source/detail?r=34464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 4 chunks +10 lines, -0 lines 0 comments Download
M tests/language/first_class_types_literals_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
karlklose
6 years, 9 months ago (2014-03-27 07:21:55 UTC) #1
Johnni Winther
lgtm
6 years, 9 months ago (2014-03-27 07:35:47 UTC) #2
kasperl
Seems like a good 'merge-to-trunk' candidate.
6 years, 9 months ago (2014-03-27 07:37:57 UTC) #3
karlklose
6 years, 9 months ago (2014-03-27 07:40:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r34464 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698