Adds subract, move wide immediate instructions to ARM64.

Adds subract, move wide immediate instructions to ARM64.

Also adds tests for move, add shift, add extended.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34715

[regis, 2014-04-03 16:57:38]

The immediate value of movz, movk, and movn is unsigned, but you handle it as
signed. See comments.

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/assembler_arm...
File runtime/vm/assembler_arm64.h (right):

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm64.h:275: void movk(Register rd, int32_t imm, int32_t
hw_idx) {
These 3 instructions actually take a uint16_t as immediate value.
You need to change the type or assert that the value is in range.
I would also add a test with bit 15 set, to verify that no sign extension occurs
by mistake.

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm64.h:280: void movn(Register rd, int32_t imm, int32_t
hw_idx) {
ditto

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm64.h:285: void movz(Register rd, int32_t imm, int32_t
hw_idx) {
ditto

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/assembler_arm...
File runtime/vm/assembler_arm64_test.cc (right):

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm64_test.cc:46: __ movz(R0, 42, 1);
You verify below that movk leaves some bits unchanged.
You could verify here that movz sets all bits:

Instead of just
__ movz(R0, 42, 1);
you could have
__ movz(R0, 42, 0);  // Overwritten by next instruction.
__ movz(R0, 42, 1);

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/simulator_arm...
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/simulator_arm...
runtime/vm/simulator_arm64.cc:298: static_cast<int64_t>(instr->Imm16Field()) <<
shift;
I think Imm16Field returns a signed value. You need to make it unsigned before
shifting it.

[zra, 2014-04-03 17:14:02]

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/assembler_arm...
File runtime/vm/assembler_arm64.h (right):

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm64.h:275: void movk(Register rd, int32_t imm, int32_t
hw_idx) {
On 2014/04/03 16:57:38, regis wrote:
> These 3 instructions actually take a uint16_t as immediate value.
> You need to change the type or assert that the value is in range.
> I would also add a test with bit 15 set, to verify that no sign extension
occurs
> by mistake.

Added a test.

The ASSERT for the immediate size is in EmitMoveWideOp, but I can move it here
if that would be more clear?

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/assembler_arm...
File runtime/vm/assembler_arm64_test.cc (right):

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm64_test.cc:46: __ movz(R0, 42, 1);
On 2014/04/03 16:57:38, regis wrote:
> You verify below that movk leaves some bits unchanged.
> You could verify here that movz sets all bits:
> 
> Instead of just
> __ movz(R0, 42, 1);
> you could have
> __ movz(R0, 42, 0);  // Overwritten by next instruction.
> __ movz(R0, 42, 1);

Done.

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/simulator_arm...
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/214233006/diff/20001/runtime/vm/simulator_arm...
runtime/vm/simulator_arm64.cc:298: static_cast<int64_t>(instr->Imm16Field()) <<
shift;
On 2014/04/03 16:57:38, regis wrote:
> I think Imm16Field returns a signed value. You need to make it unsigned before
> shifting it.

Changed to uint64_t

[regis, 2014-04-03 17:26:59]

LGTM

https://codereview.chromium.org/214233006/diff/40001/runtime/vm/assembler_arm...
File runtime/vm/assembler_arm64.h (right):

https://codereview.chromium.org/214233006/diff/40001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm64.h:374: ASSERT(Utils::IsUint(16, imm));
I missed this check before.

https://codereview.chromium.org/214233006/diff/40001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm64.h:375: ASSERT((hw_idx >= 0) && (hw_idx <= 3));
You could also write
ASSERT(Utils::IsUint(2, hw_idx));
Not clearer, I guess.

[zra, 2014-04-03 18:26:15]

Committed patchset #4 manually as r34715 (presubmit successful).