Issue 213853004: Add <eval-link> - a custom element for evaluating an expression.

Issue 213853004: Add <eval-link> - a custom element for evaluating an expression. (Closed)

Created:
6 years, 8 months ago by turnidge

Modified:
6 years, 8 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add <eval-link> - a custom element for evaluating an expression. Use <eval-link> to add a convenience toString() link for instances. In the future I plan to use <eval-link> to provide easy access to getters. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34616

Patch Set 1 #

Total comments: 2

Patch Set 2 : gen js #

Created: 6 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+947 lines, -630 lines)			Patch
M	runtime/bin/resources_sources.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1	2 chunks	+35 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	1	185 chunks	+378 lines, -312 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js.map	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html	View	1	2 chunks	+35 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View	1	185 chunks	+378 lines, -312 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js.map	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/elements.html	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/eval_link.html	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/elements.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/elements.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/lib/src/elements/eval_link.dart	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/lib/src/elements/eval_link.html	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/instance_view.html	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm with comment https://codereview.chromium.org/213853004/diff/1/runtime/bin/vmservice/client/lib/src/elements/eval_link.dart File runtime/bin/vmservice/client/lib/src/elements/eval_link.dart (right): https://codereview.chromium.org/213853004/diff/1/runtime/bin/vmservice/client/lib/src/elements/eval_link.dart#newcode28 runtime/bin/vmservice/client/lib/src/elements/eval_link.dart:28: busy = false; What if callback ...

6 years, 8 months ago (2014-03-31 23:21:50 UTC) #2

turnidge

Committed patchset #2 manually as r34616 (presubmit successful).

6 years, 8 months ago (2014-04-01 20:18:32 UTC) #3

turnidge

6 years, 8 months ago (2014-04-16 19:59:00 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/213853004/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/lib/src/elements/eval_link.dart (right):

https://codereview.chromium.org/213853004/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/elements/eval_link.dart:28: busy = false;
On 2014/03/31 23:21:51, Cutch wrote:
> What if callback completes with an error? The element will forever be busy
> because then is never fired. Add a whenComplete or catchError clause?

Done, good catch.

Expand Messages | Collapse Messages