Issue 213833013: Add a string_scanner package.

Issue 213833013: Add a string_scanner package. (Closed)

Created:
6 years, 8 months ago by nweiz

Modified:
6 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a string_scanner package. This code has been pulled out of the Shelf package. R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=34665

Patch Set 2 : code review #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+214 lines, -12 lines)			Patch
A +	pkg/string_scanner/LICENSE	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	pkg/string_scanner/README.md	View		1 chunk	+37 lines, -0 lines	0 comments	Download
A +	pkg/string_scanner/lib/string_scanner.dart	View	1	3 chunks	+48 lines, -4 lines	0 comments	Download
A	pkg/string_scanner/pubspec.yaml	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	pkg/string_scanner/test/error_format_test.dart	View		1 chunk	+110 lines, -0 lines	0 comments	Download
A +	pkg/string_scanner/test/string_scanner_test.dart	View	1	9 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo

lgtm w/ comments https://codereview.chromium.org/213833013/diff/1/pkg/string_scanner/lib/string_scanner.dart File pkg/string_scanner/lib/string_scanner.dart (right): https://codereview.chromium.org/213833013/diff/1/pkg/string_scanner/lib/string_scanner.dart#newcode5 pkg/string_scanner/lib/string_scanner.dart:5: library string_scanner; A short doc-comment on ...

6 years, 8 months ago (2014-04-02 16:30:08 UTC) #2

nweiz

https://codereview.chromium.org/213833013/diff/1/pkg/string_scanner/lib/string_scanner.dart File pkg/string_scanner/lib/string_scanner.dart (right): https://codereview.chromium.org/213833013/diff/1/pkg/string_scanner/lib/string_scanner.dart#newcode5 pkg/string_scanner/lib/string_scanner.dart:5: library string_scanner; On 2014/04/02 16:30:09, kevmoo wrote: > A ...

6 years, 8 months ago (2014-04-02 20:26:40 UTC) #3

nweiz

6 years, 8 months ago (2014-04-02 20:30:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34665 (presubmit successful).

Expand Messages | Collapse Messages