Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 213713002: Reapply change that makes path-observer more agressive with property lookups. (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply change that makes path-observer more agressive with property lookups. Additionally fixes template-iterator to be robust in the precense of these errors. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=34456

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -61 lines) Patch
M pkg/observe/lib/src/path_observer.dart View 6 chunks +43 lines, -25 lines 0 comments Download
M pkg/observe/test/path_observer_test.dart View 10 chunks +39 lines, -15 lines 0 comments Download
M pkg/polymer_expressions/lib/eval.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/smoke/lib/mirrors.dart View 1 chunk +12 lines, -1 line 0 comments Download
M pkg/smoke/test/common.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/template_binding/lib/src/template_iterator.dart View 1 1 chunk +20 lines, -7 lines 0 comments Download
M pkg/template_binding/test/node_bind_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/template_binding/test/template_binding_test.dart View 1 3 chunks +47 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
Every file that you've seen before is identical, the only new changes are in the ...
6 years, 9 months ago (2014-03-26 22:36:17 UTC) #1
Jennifer Messerly
lgtm! (we chatted about it & think it's the best we can do for now ...
6 years, 9 months ago (2014-03-26 22:59:35 UTC) #2
Siggi Cherem (dart-lang)
Thanks. I added a TODO to get some of the work started to fix upstream ...
6 years, 9 months ago (2014-03-26 23:03:59 UTC) #3
Siggi Cherem (dart-lang)
6 years, 9 months ago (2014-03-26 23:04:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r34456 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698