Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 21351002: Make the parameters map of the HTTP HeaderValue unmodifiable (Closed)

Created:
7 years, 4 months ago by Søren Gjesse
Modified:
7 years, 4 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make the parameters map of the HTTP HeaderValue unmodifiable BUG=http://dartbug.com/8951 R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=25663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -9 lines) Patch
M sdk/lib/io/http.dart View 2 chunks +4 lines, -1 line 0 comments Download
M sdk/lib/io/http_headers.dart View 7 chunks +54 lines, -8 lines 0 comments Download
M tests/standalone/io/http_headers_test.dart View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 4 months ago (2013-07-31 11:35:08 UTC) #1
Bill Hesse
lgtm
7 years, 4 months ago (2013-07-31 13:16:41 UTC) #2
Søren Gjesse
7 years, 4 months ago (2013-07-31 13:59:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25663 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698