Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2896)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 213463003: Strip out gcc preprocessor support (Closed)

Created:
6 years, 9 months ago by vsm
Modified:
6 years, 9 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Strip out gcc preprocessor support Blink IDL no longer uses #if-style syntax for enabling features. R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=34447

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -37 lines) Patch
M tools/dom/scripts/databasebuilder.py View 1 chunk +1 line, -3 lines 0 comments Download
M tools/dom/scripts/idlparser.py View 1 1 chunk +1 line, -34 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vsm
6 years, 9 months ago (2014-03-26 18:54:27 UTC) #1
terry
lgtm https://chromiumcodereview.appspot.com/213463003/diff/1/tools/dom/scripts/idlparser.py File tools/dom/scripts/idlparser.py (left): https://chromiumcodereview.appspot.com/213463003/diff/1/tools/dom/scripts/idlparser.py#oldcode424 tools/dom/scripts/idlparser.py:424: defines -- an array of pre-processor defines. minor ...
6 years, 9 months ago (2014-03-26 20:14:56 UTC) #2
terry
https://chromiumcodereview.appspot.com/213463003/diff/1/tools/dom/scripts/idlparser.py File tools/dom/scripts/idlparser.py (left): https://chromiumcodereview.appspot.com/213463003/diff/1/tools/dom/scripts/idlparser.py#oldcode424 tools/dom/scripts/idlparser.py:424: defines -- an array of pre-processor defines. oops that ...
6 years, 9 months ago (2014-03-26 20:15:43 UTC) #3
vsm
Fix comments
6 years, 9 months ago (2014-03-26 20:21:42 UTC) #4
vsm
https://chromiumcodereview.appspot.com/213463003/diff/1/tools/dom/scripts/idlparser.py File tools/dom/scripts/idlparser.py (left): https://chromiumcodereview.appspot.com/213463003/diff/1/tools/dom/scripts/idlparser.py#oldcode424 tools/dom/scripts/idlparser.py:424: defines -- an array of pre-processor defines. On 2014/03/26 ...
6 years, 9 months ago (2014-03-26 20:21:47 UTC) #5
vsm
6 years, 9 months ago (2014-03-26 20:22:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 manually as r34447 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698