Issue 213373004: Remove a failing assert from the dart2js transformer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213373004: Remove a failing assert from the dart2js transformer. (Closed)

Created:
6 years, 9 months ago by nweiz

Modified:
6 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove a failing assert from the dart2js transformer. Dart2js can now emit non-fatal messages without URIs for e.g. logging that it's suppressing warnings in another package. The assert is also no longer present in [FormattingDiagnosticHandler.handleDiagnostic]. R=rnystrom@google.com BUG=17796 Committed: https://code.google.com/p/dart/source/detail?r=34444

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

6 years, 9 months ago (2014-03-26 19:05:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34444 (presubmit successful).

Expand Messages | Collapse Messages