Issue 21319002: - Add following additional methods to the API to make returning values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21319002: - Add following additional methods to the API to make returning values (Closed)

Created:
7 years, 4 months ago by siva

Modified:
7 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Add following additional methods to the API to make returning values from Dartium easier: Dart_SetBooleanReturnValue Dart_SetIntegerReturnValue Dart_SetDoubleReturnValue - Use Isolate value stored in NativeArguments instead of calling Isolate::Current R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25676

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -8 lines)			Patch
M	runtime/include/dart_api.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.h	View	1	4 chunks	+27 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	2 chunks	+38 lines, -5 lines	0 comments	Download
M	runtime/vm/native_arguments.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://chromiumcodereview.appspot.com/21319002/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://chromiumcodereview.appspot.com/21319002/diff/1/runtime/vm/dart_api_impl.cc#newcode3599 runtime/vm/dart_api_impl.cc:3599: if (retval != Api::Null() && !Api::IsInstance(retval)) { Add ...

7 years, 4 months ago (2013-07-31 14:27:31 UTC) #2

siva

https://chromiumcodereview.appspot.com/21319002/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://chromiumcodereview.appspot.com/21319002/diff/1/runtime/vm/dart_api_impl.cc#newcode3599 runtime/vm/dart_api_impl.cc:3599: if (retval != Api::Null() && !Api::IsInstance(retval)) { On 2013/07/31 ...

7 years, 4 months ago (2013-07-31 16:23:03 UTC) #3

siva

7 years, 4 months ago (2013-07-31 18:05:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25676 (presubmit successful).

Expand Messages | Collapse Messages