Move the oauth2 library documentation to a README.

Move the oauth2 library documentation to a README.

BUG=17772
R=sethladd@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34454

[sethladd, 2014-03-26 18:57:23]

Thanks!

Does this library require dart:io? It wasn't apparent from the docs, but I might
have missed it. I saw that you wrote a server-side example. Should we make it
really clear, one way or another?

[nweiz, 2014-03-26 19:05:07]

On 2014/03/26 18:57:23, sethladd wrote:
> Thanks!
> 
> Does this library require dart:io? It wasn't apparent from the docs, but I
might
> have missed it. I saw that you wrote a server-side example. Should we make it
> really clear, one way or another?

This library doesn't directly, but the HTTP package which it uses does
currently. There's nothing about either of the libraries that's specific to the
server-side, though, so I'm wary of being too loud about how they're
server-side-only since I plan to make them work on the browser as soon as it's
possible to do so.

[kevmoo, 2014-03-26 19:10:22]

On 2014/03/26 19:05:07, nweiz wrote:
> On 2014/03/26 18:57:23, sethladd wrote:
> > Thanks!
> > 
> > Does this library require dart:io? It wasn't apparent from the docs, but I
> might
> > have missed it. I saw that you wrote a server-side example. Should we make
it
> > really clear, one way or another?
> 
> This library doesn't directly, but the HTTP package which it uses does
> currently. There's nothing about either of the libraries that's specific to
the
> server-side, though, so I'm wary of being too loud about how they're
> server-side-only since I plan to make them work on the browser as soon as it's
> possible to do so.

This does import dart:io

lib/src/handle_access_token_response.dart:7:import 'dart:io';

I think it could be possible to split this up into core + client/server package.

Not sure if that's necessary, though. Browser apps can import the html version,
server apps import the dart:io version

There is an okay split between the libraries in this package, so I think we're
good.

[nweiz, 2014-03-26 19:42:12]

On 2014/03/26 19:10:22, kevmoo wrote:
> This does import dart:io
> 
> lib/src/handle_access_token_response.dart:7:import 'dart:io';

That's true, I'd forgotten. It only uses it for ContentType, though, so the
dependency could easily be removed once I make the http_parser package I keep
talking about.
 
> I think it could be possible to split this up into core + client/server
package.
> 
> Not sure if that's necessary, though. Browser apps can import the html
version,
> server apps import the dart:io version
> 
> There is an okay split between the libraries in this package, so I think we're
> good.

I really hate the idea of splitting packages into client and server versions.
It's a band-aid over functionality that should be provided by the language that
shunts the pain onto the user instead. Beside which, it wouldn't even work for
the http package, since it needs its default client implementation to choose
between IO and HTTP.

[sethladd, 2014-03-26 20:59:11]

On 2014/03/26 19:42:12, nweiz wrote:
> On 2014/03/26 19:10:22, kevmoo wrote:
> > This does import dart:io
> > 
> > lib/src/handle_access_token_response.dart:7:import 'dart:io';
> 

> I really hate the idea of splitting packages into client and server versions.
> It's a band-aid over functionality that should be provided by the language
that
> shunts the pain onto the user instead. Beside which, it wouldn't even work for
> the http package, since it needs its default client implementation to choose
> between IO and HTTP.

I've seen other packages put two libraries into the same package.

[sethladd, 2014-03-26 20:59:45]

Since it looks like this package only works on dart:io, can you state that
clearly in the README?

[nweiz, 2014-03-26 21:35:56]

On 2014/03/26 20:59:11, sethladd wrote:
> On 2014/03/26 19:42:12, nweiz wrote:
> > On 2014/03/26 19:10:22, kevmoo wrote:
> > > This does import dart:io
> > > 
> > > lib/src/handle_access_token_response.dart:7:import 'dart:io';
> > 
> 
> > I really hate the idea of splitting packages into client and server
versions.
> > It's a band-aid over functionality that should be provided by the language
> that
> > shunts the pain onto the user instead. Beside which, it wouldn't even work
for
> > the http package, since it needs its default client implementation to choose
> > between IO and HTTP.
> 
> I've seen other packages put two libraries into the same package.

I'm not saying people don't do it, I'm saying I don't think it's a good pattern
and it won't work in this case anyway.

> Since it looks like this package only works on dart:io, can you state that
> clearly in the README?

I'm not happy about it, but done.

[sethladd, 2014-03-26 22:07:36]

lgtm

thanks again for the readme!

[nweiz, 2014-03-26 22:18:17]

Committed patchset #2 manually as r34454 (presubmit successful).