Issue 212813006: Fix JSON tests, re-enable in all cases - 2nd try

Issue 212813006: Fix JSON tests, re-enable in all cases - 2nd try (Closed)

Created:
6 years, 9 months ago by kevmoo

Modified:
6 years, 9 months ago

Reviewers:
ricow1, Lasse Reichstein Nielsen, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix JSON tests, re-enable in all cases - 2nd try R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=34457

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -203 lines)			Patch
D	tests/json/json.status	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	tests/json/json_test.dart	View	1 chunk	+0 lines, -173 lines	0 comments	Download
A +	tests/lib/convert/json2_test.dart	View	4 chunks	+12 lines, -18 lines	0 comments	Download
M	tests/standalone/io/status_file_parser_test.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/status_clean.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/test.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kevmoo

2nd try of https://codereview.chromium.org/208273003/ Removed refs to json.status in a few places. Much better now...

6 years, 9 months ago (2014-03-26 19:12:17 UTC) #1

kevmoo

Committed patchset #1 manually as r34457 (presubmit successful).

6 years, 9 months ago (2014-03-26 23:11:45 UTC) #3

ricow1

Please also remove this from the default selector list in tools/testing/dart/test_options.dart Other than that, LGTM

6 years, 9 months ago (2014-03-27 06:11:37 UTC) #4

kevmoo

On 2014/03/27 06:11:37, ricow1 wrote: > Please also remove this from the default selector list ...

6 years, 9 months ago (2014-03-27 06:22:41 UTC) #5

ricow1

6 years, 9 months ago (2014-03-27 06:43:34 UTC) #6

Message was sent while issue was closed.

On 2014/03/27 06:22:41, kevmoo wrote:
> On 2014/03/27 06:11:37, ricow1 wrote:
> > Please also remove this from the default selector list in
> > tools/testing/dart/test_options.dart
> > 
> > Other than that, LGTM
> 
> See https://codereview.chromium.org/212813006/

This link is to _this_ cl, no matter how many times I click it I don't leave the
page :-)

Expand Messages | Collapse Messages