Hoist .simpleName and .qualifiedName up to _LocalDeclarationMirrorImpl.

Hoist .simpleName and .qualifiedName up to _LocalDeclarationMirrorImpl.

Current tests already cover this change.

BUG=
R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25647

[Michael Lippautz (Google), 2013-07-30 18:47:07]

LibraryMirror and ClassMirror do not inherit from _LocalDeclarationMirror, hence
they don't profit from this, yet.

[rmacnak, 2013-07-30 19:48:37]

https://chromiumcodereview.appspot.com/21281002/diff/1/runtime/lib/mirrors_im...
File runtime/lib/mirrors_impl.dart (right):

https://chromiumcodereview.appspot.com/21281002/diff/1/runtime/lib/mirrors_im...
runtime/lib/mirrors_impl.dart:664: Symbol get simpleName => _simpleName;
If the getter just answers the field, we can just use the field.

https://chromiumcodereview.appspot.com/21281002/diff/1/runtime/lib/mirrors_im...
runtime/lib/mirrors_impl.dart:745: Symbol get qualifiedName {
Isn't this inherited now?

[Michael Lippautz (Google), 2013-07-30 19:58:18]

https://chromiumcodereview.appspot.com/21281002/diff/1/runtime/lib/mirrors_im...
File runtime/lib/mirrors_impl.dart (right):

https://chromiumcodereview.appspot.com/21281002/diff/1/runtime/lib/mirrors_im...
runtime/lib/mirrors_impl.dart:664: Symbol get simpleName => _simpleName;
On 2013/07/30 19:48:37, Ryan Macnak wrote:
> If the getter just answers the field, we can just use the field.

Done.

https://chromiumcodereview.appspot.com/21281002/diff/1/runtime/lib/mirrors_im...
runtime/lib/mirrors_impl.dart:745: Symbol get qualifiedName {
On 2013/07/30 19:48:37, Ryan Macnak wrote:
> Isn't this inherited now?

Yep, did miss this one.

[siva, 2013-07-30 20:52:25]

lgtm

[Michael Lippautz (Google), 2013-07-30 22:22:23]

Committed patchset #2 manually as r25647 (presubmit successful).