Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 21277002: Add tests for reflecting on null and Null. (Closed)

Created:
7 years, 4 months ago by rmacnak
Modified:
7 years, 4 months ago
Reviewers:
ahe, siva
CC:
reviews_dartlang.org, Michael Lippautz (Google), gbracha
Visibility:
Public.

Description

Add tests for reflecting on null and Null. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25701

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M tests/lib/lib.status View 2 chunks +2 lines, -0 lines 0 comments Download
A tests/lib/mirrors/null_test.dart View 1 chunk +31 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
rmacnak
7 years, 4 months ago (2013-07-30 18:23:01 UTC) #1
siva
lgtm
7 years, 4 months ago (2013-08-01 01:07:42 UTC) #2
rmacnak
Committed patchset #1 manually as r25701 (presubmit successful).
7 years, 4 months ago (2013-08-01 01:31:42 UTC) #3
ahe
https://codereview.chromium.org/21277002/diff/3001/tests/lib/mirrors/null_test.dart File tests/lib/mirrors/null_test.dart (right): https://codereview.chromium.org/21277002/diff/3001/tests/lib/mirrors/null_test.dart#newcode30 tests/lib/mirrors/null_test.dart:30: Expect.equals(null, NullMirror.owner); // Null belongs to no library. Where ...
7 years, 4 months ago (2013-08-06 11:13:38 UTC) #4
rmacnak
7 years, 4 months ago (2013-08-06 18:58:54 UTC) #5
Message was sent while issue was closed.
+Gilad

Powered by Google App Engine
This is Rietveld 408576698