Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 212723002: Revert "- Make ports be less predictable." (Closed)

Created:
6 years, 9 months ago by kasperl
Modified:
6 years, 9 months ago
Reviewers:
ricow1, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "- Make ports be less predictable." This reverts r34209 which is causing the x64 VM to hang when running command-line applications from within the editor. R=ricow@google.com, iposva@google.com BUG=http://dartbug.com/17806 Committed: https://code.google.com/p/dart/source/detail?r=34420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M runtime/vm/message_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/port.h View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/port.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M runtime/vm/random.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
6 years, 9 months ago (2014-03-26 11:37:21 UTC) #1
ricow1
lgtm
6 years, 9 months ago (2014-03-26 11:38:17 UTC) #2
kasperl
6 years, 9 months ago (2014-03-26 11:38:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34420 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698