Optimize String.fromCharCode.

Optimize String.fromCharCode.

BUG= http://dartbug.com/17781
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34419

[Lasse Reichstein Nielsen, 2014-03-26 09:59:59]

https://codereview.chromium.org/212423003/diff/1/runtime/lib/string_patch.dart
File runtime/lib/string_patch.dart (right):

https://codereview.chromium.org/212423003/diff/1/runtime/lib/string_patch.dar...
runtime/lib/string_patch.dart:15: if (charCode <= 0xffff) {
What should I do to get _TwoByteString._allocate too? :)

Or is it not there because unchecked use would allow building a two-byte string
with only one-byte characters?

[Søren Gjesse, 2014-03-26 10:10:33]

lgtm

https://codereview.chromium.org/212423003/diff/1/runtime/lib/string_patch.dart
File runtime/lib/string_patch.dart (right):

https://codereview.chromium.org/212423003/diff/1/runtime/lib/string_patch.dar...
runtime/lib/string_patch.dart:15: if (charCode <= 0xffff) {
On 2014/03/26 09:59:59, Lasse Reichstein Nielsen wrote:
> What should I do to get _TwoByteString._allocate too? :)
> 
> Or is it not there because unchecked use would allow building a two-byte
string
> with only one-byte characters?

I think you can just add to to string.cc and send the review to the VM guys.

[Lasse Reichstein Nielsen, 2014-03-26 11:37:14]

Committed patchset #2 manually as r34419 (presubmit successful).