Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issue 21241002: Mark two standalone tests as flaky, with bugs filed for them. (Closed)

Created:
7 years, 4 months ago by Bill Hesse
Modified:
7 years, 4 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark two standalone tests as flaky, with bugs filed for them. package watcher, directory_watcher_test and standalone/vmservice/multiple_isolate_list_test are marked as flaky. BUG=http://dartbug.com/12107, http://dartbug.com/12124 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=25613

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add sample_extension supression on mac #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +1 line, -0 lines 0 comments Download
M samples/tests/samples/samples.status View 1 1 chunk +3 lines, -0 lines 1 comment Download
M tests/standalone/standalone.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
7 years, 4 months ago (2013-07-30 12:43:34 UTC) #1
Bill Hesse
On 2013/07/30 12:43:34, Bill Hesse wrote: I'm going to add the failures of sample_extension_test on ...
7 years, 4 months ago (2013-07-30 12:55:02 UTC) #2
ricow1
LGTM with marker changed https://codereview.chromium.org/21241002/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/21241002/diff/1/tests/standalone/standalone.status#newcode28 tests/standalone/standalone.status:28: vmservice/multiple_isolate_list_test: Fail, OK # http://dartbug.com/12124 ...
7 years, 4 months ago (2013-07-30 12:58:15 UTC) #3
Bill Hesse
Committed patchset #2 manually as r25613 (presubmit successful).
7 years, 4 months ago (2013-07-30 13:09:37 UTC) #4
ricow1
7 years, 4 months ago (2013-07-30 13:10:29 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/21241002/diff/7001/samples/tests/samples/samp...
File samples/tests/samples/samples.status (right):

https://codereview.chromium.org/21241002/diff/7001/samples/tests/samples/samp...
samples/tests/samples/samples.status:41: standalone/sample_extension_test: Fail,
Pass
do we have a bug for this?

Powered by Google App Engine
This is Rietveld 408576698