Issue 2123353002: Add a skip parameter to expect().

Issue 2123353002: Add a skip parameter to expect(). (Closed)

Created:
4 years, 5 months ago by nweiz

Modified:
4 years, 5 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add a skip parameter to expect(). Closes #394 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/f377edf3d16f09835f85453d931b72e2a0813cbf

Patch Set 2 : Code review changes #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -2 lines)			Patch
M	CHANGELOG.md	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/src/backend/invoker.dart	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	lib/src/frontend/expect.dart	View		1 chunk	+28 lines, -1 line	0 comments	Download
M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	test/runner/skip_expect_test.dart	View		1 chunk	+174 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kevmoo

LGTM don't forget to update the version https://codereview.chromium.org/2123353002/diff/1/lib/src/backend/invoker.dart File lib/src/backend/invoker.dart (right): https://codereview.chromium.org/2123353002/diff/1/lib/src/backend/invoker.dart#newcode238 lib/src/backend/invoker.dart:238: /// Note ...

4 years, 5 months ago (2016-07-06 20:30:42 UTC) #2

nweiz

https://codereview.chromium.org/2123353002/diff/1/lib/src/backend/invoker.dart File lib/src/backend/invoker.dart (right): https://codereview.chromium.org/2123353002/diff/1/lib/src/backend/invoker.dart#newcode238 lib/src/backend/invoker.dart:238: /// Note that this *does not* mark the test ...

4 years, 5 months ago (2016-07-06 21:14:18 UTC) #4

nweiz

4 years, 5 months ago (2016-07-06 21:14:33 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f377edf3d16f09835f85453d931b72e2a0813cbf (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages