Issue 212163005: Speed up toLowerCase, by manually inlining the upper-case part.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212163005: Speed up toLowerCase, by manually inlining the upper-case part. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen

Modified:
6 years, 9 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org, srdjan

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Speed up toLowerCase, by manually inlining the upper-case part. Some benchmarks show up to 25% faster toLowerCase. BUG= R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=34423

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -18 lines)			Patch
	M	runtime/lib/string_patch.dart	View	1	2 chunks	+11 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/212163005/diff/1/runtime/lib/string_patch.dart File runtime/lib/string_patch.dart (right): https://codereview.chromium.org/212163005/diff/1/runtime/lib/string_patch.dart#newcode827 runtime/lib/string_patch.dart:827: // Ranges: 0x41-0x5a ('A' - 'Z'), 0xc0-0xd6, 0xd8-0xde. ...

6 years, 9 months ago (2014-03-26 11:37:50 UTC) #2

Anders Johnsen

https://codereview.chromium.org/212163005/diff/1/runtime/lib/string_patch.dart File runtime/lib/string_patch.dart (right): https://codereview.chromium.org/212163005/diff/1/runtime/lib/string_patch.dart#newcode827 runtime/lib/string_patch.dart:827: // Ranges: 0x41-0x5a ('A' - 'Z'), 0xc0-0xd6, 0xd8-0xde. On ...

6 years, 9 months ago (2014-03-26 11:39:12 UTC) #3

Anders Johnsen

6 years, 9 months ago (2014-03-26 12:20:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34423 (presubmit successful).

Expand Messages | Collapse Messages