Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 211873003: Incremental tuning/cleanup of inlining: --print-inline-tree changed to --print-inlining-tree. (Closed)

Created:
6 years, 9 months ago by srdjan
Modified:
6 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Incremental tuning/cleanup of inlining: --print-inline-tree changed to --print-inlining-tree; print also methods that were not inlined. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34451

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -69 lines) Patch
M runtime/vm/compiler.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_inliner.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 2 3 4 21 chunks +152 lines, -62 lines 0 comments Download
M runtime/vm/il_printer.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 2 3 4 5 chunks +12 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
6 years, 9 months ago (2014-03-26 00:05:34 UTC) #1
Cutch
lgtm with a small suggestion. https://codereview.chromium.org/211873003/diff/130002/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://codereview.chromium.org/211873003/diff/130002/runtime/vm/flow_graph_inliner.cc#newcode286 runtime/vm/flow_graph_inliner.cc:286: const bool only_recognized_methods = ...
6 years, 9 months ago (2014-03-26 20:26:37 UTC) #2
srdjan
https://codereview.chromium.org/211873003/diff/130002/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://codereview.chromium.org/211873003/diff/130002/runtime/vm/flow_graph_inliner.cc#newcode286 runtime/vm/flow_graph_inliner.cc:286: const bool only_recognized_methods = On 2014/03/26 20:26:37, Cutch wrote: ...
6 years, 9 months ago (2014-03-26 21:05:31 UTC) #3
srdjan
6 years, 9 months ago (2014-03-26 21:24:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r34451 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698