Issue 21184003: Added a flag --append to docgen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21184003: Added a flag --append to docgen. (Closed)

Created:
7 years, 4 months ago by janicejl

Modified:
7 years, 4 months ago

Reviewers:
Bob Nystrom

CC:
Emily Fortuna, Tate Mandel, Alan Knight

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added a flag --append to docgen. Results of docgen append together if append flag is set. BUG= R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=25624

Patch Set 6 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -12 lines)			Patch
		pkg/docgen/bin/docgen.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
		pkg/docgen/lib/docgen.dart	View	1	7 chunks	+15 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One nit, otherwise LGTM. https://codereview.chromium.org/21184003/diff/1/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/21184003/diff/1/pkg/docgen/lib/docgen.dart#newcode205 pkg/docgen/lib/docgen.dart:205: bool outputToYaml:true, bool append: false}) ...

7 years, 4 months ago (2013-07-30 16:23:28 UTC) #2

janicejl

7 years, 4 months ago (2013-07-30 16:57:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #6 manually as r25624 (presubmit successful).

Expand Messages | Collapse Messages

Issue 21184003: Added a flag --append to docgen. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Messages