Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 21182002: Allow "bulk editing" of the CssStyleDeclaration objects in an ElementList as well (Closed)

Created:
7 years, 4 months ago by Emily Fortuna
Modified:
7 years, 4 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow "bulk editing" of the CssStyleDeclaration objects in an ElementList as well. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=25623

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -49 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 5 chunks +70 lines, -26 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 5 chunks +57 lines, -13 lines 0 comments Download
M tests/html/cssstyledeclaration_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 5 chunks +39 lines, -10 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Emily Fortuna
7 years, 4 months ago (2013-07-30 00:28:19 UTC) #1
blois
https://codereview.chromium.org/21182002/diff/11001/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate File tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate (right): https://codereview.chromium.org/21182002/diff/11001/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate#newcode28 tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate:28: class $(CLASSNAME)Set $EXTENDS with $(CLASSNAME)Mixin { I don't think ...
7 years, 4 months ago (2013-07-30 00:45:18 UTC) #2
Emily Fortuna
ptal
7 years, 4 months ago (2013-07-30 01:06:15 UTC) #3
blois
lgtm
7 years, 4 months ago (2013-07-30 16:08:54 UTC) #4
Emily Fortuna
7 years, 4 months ago (2013-07-30 16:55:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r25623 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698