Issue 21169002: Int32 constants should be const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21169002: Int32 constants should be const. (Closed)

Created:
7 years, 4 months ago by Chris Bracken

Modified:
7 years, 4 months ago

Reviewers:
justinfagnani

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	pkg/fixnum/lib/src/int32.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Chris Bracken

Note: Int64 should really also have a const constructor and final fields. Will look at ...

7 years, 4 months ago (2013-07-29 22:12:01 UTC) #1

Chris Bracken

7 years, 4 months ago (2013-07-30 20:34:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25634 (presubmit successful).