Issue 21162003: Fix for NPE when convert error without source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21162003: Fix for NPE when convert error without source. (Closed)

Created:
7 years, 4 months ago by scheglov

Modified:
7 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for NPE when convert error without source. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=25615

Patch Set 2 : Tweaks for path to Source convertion in parseDartFile() #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	pkg/analyzer_experimental/lib/analyzer.dart	View	1	1 chunk	+7 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scheglov

PTAL I've decided to do both - to absolute and early check.

7 years, 4 months ago (2013-07-29 22:33:40 UTC) #3

Brian Wilkerson

LGTM https://codereview.chromium.org/21162003/diff/5001/pkg/analyzer_experimental/lib/analyzer.dart File pkg/analyzer_experimental/lib/analyzer.dart (right): https://codereview.chromium.org/21162003/diff/5001/pkg/analyzer_experimental/lib/analyzer.dart#newcode32 pkg/analyzer_experimental/lib/analyzer.dart:32: if (source == null) { We might also ...

7 years, 4 months ago (2013-07-30 14:03:01 UTC) #4

scheglov

7 years, 4 months ago (2013-07-30 14:53:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r25615 (presubmit successful).

Expand Messages | Collapse Messages

Issue 21162003: Fix for NPE when convert error without source. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Tweaks for path to Source convertion in parseDartFile() #

Messages