Issue 21159002: Implements far-branches on ARM.

Issue 21159002: Implements far-branches on ARM. (Closed)

Created:
7 years, 4 months ago by zra

Modified:
7 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implements far-branches on ARM. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=25617

Patch Set 4 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -50 lines)			Patch
M	runtime/vm/assembler.h	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler.cc	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1 2 3	6 chunks	+172 lines, -46 lines	0 comments	Download
M	runtime/vm/assembler_mips.h	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_mips.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/constants_arm.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/21159002/diff/19001/runtime/vm/assembler_arm.cc File runtime/vm/assembler_arm.cc (right): https://codereview.chromium.org/21159002/diff/19001/runtime/vm/assembler_arm.cc#newcode1717 runtime/vm/assembler_arm.cc:1717: offset -= 8; Opportunity for cleanup: Use Instr::kPCReadOffset ...

7 years, 4 months ago (2013-07-29 21:48:04 UTC) #2

zra

Committed patchset #4 manually as r25617 (presubmit successful).

7 years, 4 months ago (2013-07-30 15:33:42 UTC) #3

zra

7 years, 4 months ago (2013-08-01 15:15:58 UTC) #4

Message was sent while issue was closed.

Looks like I forgot to send this back on Tuesday.

https://codereview.chromium.org/21159002/diff/19001/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/21159002/diff/19001/runtime/vm/assembler_arm....
runtime/vm/assembler_arm.cc:1717: offset -= 8;
On 2013/07/29 21:48:04, regis wrote:
> Opportunity for cleanup:
> Use Instr::kPCReadOffset instead of 8.

Done.

https://codereview.chromium.org/21159002/diff/19001/runtime/vm/assembler_arm....
runtime/vm/assembler_arm.cc:1725: offset -= 8;
On 2013/07/29 21:48:04, regis wrote:
> ditto

Done.

https://codereview.chromium.org/21159002/diff/19001/runtime/vm/assembler_arm....
runtime/vm/assembler_arm.cc:1738: return ((((inst & kBranchOffsetMask) << 8) >>
6) + 8);
On 2013/07/29 21:48:04, regis wrote:
> ditto

Done.

https://codereview.chromium.org/21159002/diff/19001/runtime/vm/assembler_arm....
runtime/vm/assembler_arm.cc:1761: if (((movt & 0xfff0f000) == 0xe340c000) &&  //
movt TMP, high
On 2013/07/29 21:48:04, regis wrote:
> For clarity, I would use the name IP instead of TMP at this low level. TMP is
> rather used in architecture independent files.

Renamed all instances in this file.

Expand Messages | Collapse Messages