Issue 21155004: Clean up exceptions thrown in pkg/fixnum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21155004: Clean up exceptions thrown in pkg/fixnum. (Closed)

Created:
7 years, 4 months ago by Chris Bracken

Modified:
7 years, 4 months ago

Reviewers:
justinfagnani

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Clean up exceptions thrown in pkg/fixnum. * Throw ArgumentError rather than string. * Don't wrap ArgumentError params in strings. Original Issue: https://code.google.com/p/dart/issues/detail?id=9909 BUG= R=justinfagnani@google.com Committed: https://code.google.com/p/dart/source/detail?r=25635

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	pkg/fixnum/lib/src/int32.dart	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
	M	pkg/fixnum/lib/src/int64.dart	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Chris Bracken

7 years, 4 months ago (2013-07-30 20:40:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r25635 (presubmit successful).