Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 21145004: Add Float32x4List.fromList to runtime implementation and some tests (Closed)

Created:
7 years, 4 months ago by Cutch
Modified:
7 years, 4 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add Float32x4List.fromList to runtime implementation and some tests R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=25586

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -0 lines) Patch
M runtime/lib/typed_data.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M sdk/lib/typed_data/typed_data.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/typed_data/float32x4_cross_test.dart View 1 1 chunk +50 lines, -0 lines 0 comments Download
A tests/lib/typed_data/float32x4_transpose_test.dart View 1 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cutch
7 years, 4 months ago (2013-07-29 20:51:05 UTC) #1
zra
lgtm https://codereview.chromium.org/21145004/diff/1/tests/lib/typed_data/float32x4_cross_test.dart File tests/lib/typed_data/float32x4_cross_test.dart (right): https://codereview.chromium.org/21145004/diff/1/tests/lib/typed_data/float32x4_cross_test.dart#newcode36 tests/lib/typed_data/float32x4_cross_test.dart:36: for (int i = 0; i < 2000; ...
7 years, 4 months ago (2013-07-29 21:13:25 UTC) #2
Cutch
https://codereview.chromium.org/21145004/diff/1/tests/lib/typed_data/float32x4_cross_test.dart File tests/lib/typed_data/float32x4_cross_test.dart (right): https://codereview.chromium.org/21145004/diff/1/tests/lib/typed_data/float32x4_cross_test.dart#newcode36 tests/lib/typed_data/float32x4_cross_test.dart:36: for (int i = 0; i < 2000; i++) ...
7 years, 4 months ago (2013-07-29 21:29:49 UTC) #3
Cutch
7 years, 4 months ago (2013-07-29 21:32:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25586 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698