Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 211363007: Avoids MIPS32r2 instructions on MIPS32. (Closed)

Created:
6 years, 9 months ago by zra
Modified:
6 years, 9 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Avoids MIPS32r2 instructions on MIPS32. Adds necessary feature detection to tell the difference. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=34391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/assembler_mips_test.cc View 2 chunks +16 lines, -8 lines 0 comments Download
M runtime/vm/cpu_mips.h View 3 chunks +14 lines, -0 lines 0 comments Download
M runtime/vm/cpu_mips.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
6 years, 9 months ago (2014-03-25 21:04:38 UTC) #1
regis
LGTM
6 years, 9 months ago (2014-03-25 21:29:54 UTC) #2
zra
6 years, 9 months ago (2014-03-25 21:31:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34391 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698