Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Issue 21131009: added a warning if no package root is passed in for a single file. (Closed)

Created:
7 years, 4 months ago by janicejl
Modified:
7 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
Emily Fortuna
Visibility:
Public.

Description

added a warning if no package root is passed in for a single file. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=25629

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M pkg/docgen/lib/docgen.dart View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
janicejl
7 years, 4 months ago (2013-07-30 17:30:12 UTC) #1
Bob Nystrom
LGTM.
7 years, 4 months ago (2013-07-30 18:22:02 UTC) #2
janicejl
7 years, 4 months ago (2013-07-30 18:43:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r25629 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698