Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 21128007: Mark pkg/path/test/browser_test as failing on browsers. (Closed)

Created:
7 years, 4 months ago by ricow1
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark pkg/path/test/browser_test as failing on browsers. The test is using the io library (which is not available, neither imported) Filed dartbug.com/12121 R=ager@google.com Committed: https://code.google.com/p/dart/source/detail?r=25604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
7 years, 4 months ago (2013-07-30 05:49:32 UTC) #1
Mads Ager (google)
lgtm
7 years, 4 months ago (2013-07-30 05:53:39 UTC) #2
ricow1
Committed patchset #1 manually as r25604 (presubmit successful).
7 years, 4 months ago (2013-07-30 05:57:23 UTC) #3
Bob Nystrom
7 years, 4 months ago (2013-07-30 15:51:29 UTC) #4
Message was sent while issue was closed.
On 2013/07/30 05:57:23, ricow1 wrote:
> Committed patchset #1 manually as r25604 (presubmit successful).

LGTM. Sorry about this.

Powered by Google App Engine
This is Rietveld 408576698