Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 211273002: Rename "inputPre" to "mainEditorPane". (Closed)

Created:
6 years, 9 months ago by ahe
Modified:
6 years, 9 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, lukechurch
Visibility:
Public.

Description

Rename "inputPre" to "mainEditorPane". R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=34418

Patch Set 1 #

Patch Set 2 : Merged with r34416 #

Patch Set 3 : Also update test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -48 lines) Patch
M dart/site/try/src/editor.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M dart/site/try/src/interaction_manager.dart View 6 chunks +14 lines, -13 lines 0 comments Download
M dart/site/try/src/ui.dart View 14 chunks +22 lines, -21 lines 0 comments Download
M dart/tests/try/paste_content_rewriting_test.dart View 1 2 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
6 years, 9 months ago (2014-03-25 14:21:28 UTC) #1
kasperl
LGTM.
6 years, 9 months ago (2014-03-25 14:38:03 UTC) #2
ahe
Thank you, Kasper! I had forgotten the test. I've uploaded a new version which includes ...
6 years, 9 months ago (2014-03-26 11:27:06 UTC) #3
ahe
6 years, 9 months ago (2014-03-26 11:27:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r34418 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698