Implement MethodMirror.location in the VM.

Implement MethodMirror.location in the VM.

R=gbracha@google.com, hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34400

[hausner, 2014-03-25 20:59:57]

VM changes LGTM.

[gbracha, 2014-03-25 21:08:35]

tests lgtm with comments.

https://codereview.chromium.org/211243009/diff/1/tests/lib/mirrors/method_mir...
File tests/lib/mirrors/method_mirror_location_other.dart (right):

https://codereview.chromium.org/211243009/diff/1/tests/lib/mirrors/method_mir...
tests/lib/mirrors/method_mirror_location_other.dart:16:
spaceIntentedInOtherFile() {}
Should this be spaceIndentedInOtherFile?

https://codereview.chromium.org/211243009/diff/1/tests/lib/mirrors/method_mir...
tests/lib/mirrors/method_mirror_location_other.dart:18: tabIntentedInOtherFile()
{}
ditto

https://codereview.chromium.org/211243009/diff/1/tests/lib/mirrors/method_mir...
File tests/lib/mirrors/method_mirror_location_test.dart (right):

https://codereview.chromium.org/211243009/diff/1/tests/lib/mirrors/method_mir...
tests/lib/mirrors/method_mirror_location_test.dart:37: spaceIntentedInMainFile()
{}
Again, spaceIntented should be spaceIndented

https://codereview.chromium.org/211243009/diff/1/tests/lib/mirrors/method_mir...
tests/lib/mirrors/method_mirror_location_test.dart:38: tabIntentedInMainFile()
{}
and here too.

[rmacnak, 2014-03-26 00:34:35]

Fixed typos. Added the interface to the dart:mirrors API. Fixed type warnings.
PTAL.

[gbracha, 2014-03-26 00:36:18]

lgtm

[rmacnak, 2014-03-26 00:45:01]

Committed patchset #2 manually as r34400 (presubmit successful).

[Jacob, 2014-03-27 01:25:02]

On 2014/03/26 00:45:01, Ryan Macnak wrote:
> Committed patchset #2 manually as r34400 (presubmit successful).

Thanks for implementing this so quickly!
It is working perfectly for my use case of enabling "go to definition" for
methods displayed in the DevTools.