Inline CreateTypedefMirror and get rid of LazyXXXMirror

Also fixes issue 11897.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25689

[Michael Lippautz (Google), 2013-07-31 01:59:54]

This CL moves some of the missing deps for CreateClassMirror() to native code.
For now we don't cache FunctionTypeMirrors (as previosly done by LazyMirrors),
as they will get canonicalized/cached by reflectClass() in the near future.

Peter: Should I create a new bug for this test, or do you want to group missing
features? I am trying to add tests for things we didn't cover along the way of
converting mirrors to native API.

[rmacnak, 2013-07-31 20:24:37]

https://chromiumcodereview.appspot.com/21124011/diff/9001/runtime/lib/mirrors...
File runtime/lib/mirrors_impl.dart (right):

https://chromiumcodereview.appspot.com/21124011/diff/9001/runtime/lib/mirrors...
runtime/lib/mirrors_impl.dart:127: FunctionTypeMirror _lookupFunctionTypeMirror(
Dead code.

[Michael Lippautz (Google), 2013-07-31 20:33:25]

https://chromiumcodereview.appspot.com/21124011/diff/9001/runtime/lib/mirrors...
File runtime/lib/mirrors_impl.dart (right):

https://chromiumcodereview.appspot.com/21124011/diff/9001/runtime/lib/mirrors...
runtime/lib/mirrors_impl.dart:127: FunctionTypeMirror _lookupFunctionTypeMirror(
On 2013/07/31 20:24:37, Ryan Macnak wrote:
> Dead code.

Done.

[Michael Lippautz (Google), 2013-07-31 20:56:11]

Sorry for the spam. Got rid of even more dead code.

[siva, 2013-07-31 23:10:57]

lgtm

https://chromiumcodereview.appspot.com/21124011/diff/9001/tests/lib/lib.status
File tests/lib/lib.status (right):

https://chromiumcodereview.appspot.com/21124011/diff/9001/tests/lib/lib.statu...
tests/lib/lib.status:8: mirrors/function_type_mirror_test: Fail
Please add an issue for this.

[Michael Lippautz (Google), 2013-07-31 23:30:57]

https://chromiumcodereview.appspot.com/21124011/diff/9001/tests/lib/lib.status
File tests/lib/lib.status (right):

https://chromiumcodereview.appspot.com/21124011/diff/9001/tests/lib/lib.statu...
tests/lib/lib.status:8: mirrors/function_type_mirror_test: Fail
On 2013/07/31 23:10:57, siva wrote:
> Please add an issue for this.

Done.

[Michael Lippautz (Google), 2013-07-31 23:31:22]

Committed patchset #7 manually as r25689 (presubmit successful).

[ahe, 2013-08-06 11:10:06]

https://codereview.chromium.org/21124011/diff/21001/tests/lib/mirrors/functio...
File tests/lib/mirrors/function_type_mirror_test.dart (right):

https://codereview.chromium.org/21124011/diff/21001/tests/lib/mirrors/functio...
tests/lib/mirrors/function_type_mirror_test.dart:15: FunctionTypeMirror ftm =
tm.referent;
What is tm.referent? It is not in the API.

[rmacnak, 2013-08-06 16:32:40]

https://codereview.chromium.org/21124011/diff/21001/tests/lib/mirrors/functio...
File tests/lib/mirrors/function_type_mirror_test.dart (right):

https://codereview.chromium.org/21124011/diff/21001/tests/lib/mirrors/functio...
tests/lib/mirrors/function_type_mirror_test.dart:15: FunctionTypeMirror ftm =
tm.referent;
On 2013/08/06 11:10:06, ahe wrote:
> What is tm.referent? It is not in the API.

Hm, the API calls this value.

[ahe, 2013-08-06 16:41:09]

https://codereview.chromium.org/21124011/diff/21001/tests/lib/mirrors/functio...
File tests/lib/mirrors/function_type_mirror_test.dart (right):

https://codereview.chromium.org/21124011/diff/21001/tests/lib/mirrors/functio...
tests/lib/mirrors/function_type_mirror_test.dart:15: FunctionTypeMirror ftm =
tm.referent;
On 2013/08/06 16:32:40, Ryan Macnak wrote:
> On 2013/08/06 11:10:06, ahe wrote:
> > What is tm.referent? It is not in the API.
> 
> Hm, the API calls this value.

On which line in
https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/sdk/...
do you see the word "referent"?

I can't find it :-)

[rmacnak, 2013-08-06 20:40:26]

On 2013/08/06 16:41:09, ahe wrote:
>
https://codereview.chromium.org/21124011/diff/21001/tests/lib/mirrors/functio...
> File tests/lib/mirrors/function_type_mirror_test.dart (right):
> 
>
https://codereview.chromium.org/21124011/diff/21001/tests/lib/mirrors/functio...
> tests/lib/mirrors/function_type_mirror_test.dart:15: FunctionTypeMirror ftm =
> tm.referent;
> On 2013/08/06 16:32:40, Ryan Macnak wrote:
> > On 2013/08/06 11:10:06, ahe wrote:
> > > What is tm.referent? It is not in the API.
> > 
> > Hm, the API calls this value.
> 
> On which line in
>
https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/sdk/...
> do you see the word "referent"?
> 
> I can't find it :-)

What has been implemented as TypedefMirror.referent is what the API calls
TypedefMirror.value. I'll open a CL to reconcile this.

[ahe, 2013-08-06 20:50:57]

On 2013/08/06 20:40:26, Ryan Macnak wrote:
> What has been implemented as TypedefMirror.referent is what the API calls
> TypedefMirror.value. I'll open a CL to reconcile this.

Thank you.