Refactor custom element tests

Refactor custom element tests

R=blois@google.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25589

[vsm, 2013-07-29 21:00:02]

https://chromiumcodereview.appspot.com/21124003/diff/1/tests/html/custom_elem...
File tests/html/custom_elements_test.dart (right):

https://chromiumcodereview.appspot.com/21124003/diff/1/tests/html/custom_elem...
tests/html/custom_elements_test.dart:22: group('basic', () {
These tests are fixed by the accompanying blink CL.

https://chromiumcodereview.appspot.com/21124003/diff/1/tests/html/custom_elem...
tests/html/custom_elements_test.dart:59: group('register', () {
We'll get these tests to pass in the near term, but they are marked fail for
now.

https://chromiumcodereview.appspot.com/21124003/diff/1/tests/html/custom_elem...
tests/html/custom_elements_test.dart:101: group('preregister', () {
We still need to nail down the semantics here.

[blois, 2013-07-29 21:04:54]

lgtm

https://chromiumcodereview.appspot.com/21124003/diff/1/tests/html/custom_elem...
File tests/html/custom_elements_test.dart (right):

https://chromiumcodereview.appspot.com/21124003/diff/1/tests/html/custom_elem...
tests/html/custom_elements_test.dart:41: expect(queryById is Element, isTrue);
Is this an UnknownElement at this point? If so, should we validate that?

[blois, 2013-07-29 21:05:47]

https://chromiumcodereview.appspot.com/21124003/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://chromiumcodereview.appspot.com/21124003/diff/1/tests/html/html.status...
tests/html/html.status:10: custom_elements_test/register: Fail
Is the first group passing for dart2js as well?

[Siggi Cherem (dart-lang), 2013-07-29 21:28:56]

lgtm

[vsm, 2013-07-29 21:43:35]

https://chromiumcodereview.appspot.com/21124003/diff/1/tests/html/custom_elem...
File tests/html/custom_elements_test.dart (right):

https://chromiumcodereview.appspot.com/21124003/diff/1/tests/html/custom_elem...
tests/html/custom_elements_test.dart:41: expect(queryById is Element, isTrue);
On Dartium it specifically is not an UnknownElement.  The concrete type should
be HTMLElement.  

But I'm not sure we can enforce that on other browsers.

On 2013/07/29 21:04:54, blois wrote:
> Is this an UnknownElement at this point? If so, should we validate that?

https://chromiumcodereview.appspot.com/21124003/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://chromiumcodereview.appspot.com/21124003/diff/1/tests/html/html.status...
tests/html/html.status:10: custom_elements_test/register: Fail
No - it's breaking at compile time due to extends Element.  I think I'll need to
split the tests.  I'll do that and update the CL.

On 2013/07/29 21:05:47, blois wrote:
> Is the first group passing for dart2js as well?

[vsm, 2013-07-29 21:58:11]

PTAL

[blois, 2013-07-29 22:24:16]

lgtm

[vsm, 2013-07-29 22:27:07]

Committed patchset #2 manually as r25589 (presubmit successful).