Issue 21119002: Implement reflect() with Dart code, InstanceMirror.type and ClosureMirror.function with internal co…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21119002: Implement reflect() with Dart code, InstanceMirror.type and ClosureMirror.function with internal co… (Closed)

Created:
7 years, 4 months ago by rmacnak

Modified:
7 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, ahe, Michael Lippautz (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement reflect() with Dart code, InstanceMirror.type and ClosureMirror.function with internal code. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25594

Patch Set 1 : #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -122 lines)			Patch
M	runtime/lib/mirrors.cc	View	4 chunks	+9 lines, -99 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	5 chunks	+27 lines, -20 lines	1 comment	Download
M	runtime/tests/vm/dart/isolate_mirror_local_test.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rmacnak

https://codereview.chromium.org/21119002/diff/5001/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/21119002/diff/5001/runtime/lib/mirrors_impl.dart#newcode315 runtime/lib/mirrors_impl.dart:315: native 'Object_runtimeType'; Woo! Reusing a primitive.

7 years, 4 months ago (2013-07-29 18:45:06 UTC) #1

rmacnak

7 years, 4 months ago (2013-07-29 23:57:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25594 (presubmit successful).

Expand Messages | Collapse Messages